forked from dotnet/emsdk
-
Notifications
You must be signed in to change notification settings - Fork 0
[WIP] Add Node build artifact to build-deps.yml #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Blackhex
wants to merge
13
commits into
build-pipeline-for-deps
Choose a base branch
from
build-deps-node
base: build-pipeline-for-deps
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b061b9 to
4ba5a4c
Compare
d0caec6 to
2d366ef
Compare
eukarpov
reviewed
Feb 3, 2023
.github/workflows/build-deps.yml
Outdated
| New-Item -ItemType Directory -Force -Path emsdk/emscripten | ||
| Expand-Archive -LiteralPath emscripten_package.zip -DestinationPath emsdk\emscripten | ||
| Expand-Archive -LiteralPath llvm-arm64.zip -DestinationPath emsdk | ||
| Expand-Archive -LiteralPath node-arm64.zip -DestinationPath emsdk\node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build emsdk arm64 was supposed to be used for llvm emscripten package as part of emscripten_build job. I suggest to create separate job for emsdk release which will have dependencies on emscripten_build and build-nodejs-arm64
c383a97 to
040f804
Compare
cd78c1a to
3ebda06
Compare
02c6aaf to
f97ea93
Compare
152b576 to
9d85ba2
Compare
This reverts commit f55ecf5.
989c687 to
9d85ba2
Compare
9d85ba2 to
cf44a56
Compare
Pipeline to build arm64 version of LLVM, node.js, Binaryen Package wasm-binaries for arm64 based on LLVM, Binaryen and emscripten builds.
f0ecdb0 to
955f72b
Compare
…210.3 (dotnet#294) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
70cae69 to
560b140
Compare
560b140 to
ff4ae15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.